No Player Shipyard Penalty

What this mod does:

This mod adjusts the shipsalefactor parameter in order to reduce or fully remove the penalty that the player has when selling ships from a player shipyard to the AI.

Lite version sets shipsalefactor to 0. 6666 so that when your shipyard is set to 150% sell price in Logistical Overview it will be the same price as if you sold the ship by hand to the AI.

Full version sets shipsalefactor to 1. 0 so that when your shipyard is set to 100% sell price in Logistical Overview it will be the same price as if you sold the ship by hand to the AI.

In the Full version you regain the ability to leverage your economic superiority to sell to an AI that has no other option at 150% the normal price, just like the Logistics Overview slider would have you believe. You can finally discount to encourage sales or price gouge the AI based on the market competition in your corner of the galaxy again.

Why does this mod even exist?

In X4 v3. 0 Egosoft established a 70% penalty on player shipyard sales in order to reduce player incomes, however they didn't apply the penalty when selling a ship by hand. This creates a toxic and un-immersive gameplay loop where the player is incentivized to close their shipyard to the public and then sell all ships one at a time by hand to the AI in order to maximize profits. The AI then immediately destroys the ship and does not even use it in their war efforts. I think that's dumb.

Most people don't realize, but the AI does in fact shop around for the best available price for their ships, but the default 70% penalty in X4 means that the player will always be the best deal. At a glace this sounds nice right? The AI will always buy from the player, but it's really more insidious. You are always giving the AI a 3 for 1 special on ships and losing out on money you could be making by just selling the completed ship by hand.

How are ship sales calculated?

It goes like this:

(((Wares value  shipsalefactor) shipyard Logistics Overview slider value) any rep bonuses) = Shipyard Sale price

(Wares value any rep bonuses) = Manual Sale price.

E.g. (((1000 . 30) 100%) 1. 0) = 300

(1000 1. 0) = 1000

Which means your shipyard sale at the default 100% slider sold for 70% LESS than a manual sale.

E.g. (((1000 . 30) 150%) 1. 0) = 450

(1000 1. 0) = 1000

Which means your shipyard sale at max slider sold for 45% LESS than a manual sale.

E.g. (((1000 . 6666) 150%) * 1. 0) = 100