Magic Effect and Spell Engine Fixes - F4SE

About this mod:

F4SE plugin that fixes a few engine bugs that affect Spells, inventory item Enhancements and Perks ("effects") on NPCs.

1) Fixes a bug that prevents certain effects from being reapplied on NPCs after:

- equipping an item on them in the Container Menu ("trade menu")

- calling Disable() on them

- their parent Cell unloads (i.e. they get far from the player)

- fast traveling to a distant location with them (relevent for followers only)

2) Fixes a bug that can randomly cause the same effect (e.g. + 2 Perception ("Ability Spell")) to get applied on an NPC multiple times by the same source inventory item

The plugin comes with a custom Magic Effect manager that requests the vanilla code to reevaluate these effects both on a save game load and periodically (this should be part of the vanilla background process that does this for Cloak effects for example).

Here's an article about these effects in general and the "NPCs losing their magic effects" bug (credits: fadingsignal).

Another article that also describes how game breaking could be when Power Armors lose their effects (credits: PJMail).

Notes:

- the plugin does not change the vanilla behavior of Spells, Perks or Magic Effects beyond fixing these issues

- I made a mod that only patched the Container Menu code a few days ago; I decided to merge it into this one (no longer available)

- the plugin fixes the buggy code for all NPCs, not just for companions

- the plugin's multithreaded: while the Magic Effect manager is lightweight, it runs in another thread like any background process

- the manager and the ContainerMenu patch can be completely turned off with in the INI (for mod vs. vanilla comparison)

- the plugin does not make NPCs persistent

- thanks Sranger for reminding me about this issue

Compatibility:

Should be compatible with anything.

I made two versions; for non Next-Gen and Next-Gen game versions (both address independent).

Requirements:

Fallout 4 Script Extender (F4SE)[/s