Map Crash Fix

Description

Fixes a crash that occurs when you have a few top-level widgets (e.g. from other mods) and you open the map UI. Also fixes the issue where the pause menu can get stuck in a visible but uncloseable state. (Unclear if it also fixes the stuck upgrade pickup dialog; feedback on that would be appreciated)

Installation instructions

Unpack the contents of the zip and put it in pseudoregalia/Content/Paks, e.g. on my computer it's

C:\Program Files (x86)\Steam\steamapps\common\Pseudoregalia\pseudoregalia\Content\Paks

More notes

All this patch does is it adds a Delay Until Next Tick before UI_MentalMap's Construct handler.

This also seems to fix the menu softlock issue which I'd previous attempted to fix with Menu Softlock Fix. The old fix just made the orphaned widgets invisible, so it was a bit of a hack. Anyway, it seems that you only need this mod to fix both issues.

I don't fully understand why this works. One thing that is suspect is that UI_MentalMap's Construct handler itself calls AddToViewport on another widget. This could be bad if UE assumes the widget tree is immutable during a widget's Construct. One possible explanation is that the inner AddToViewport could cause the container of top-level widgets to resize, freeing the old container mid-iteration and leaving dangling pointers pointing at freed memory. This could lead to all sorts of weirdness ranging from orphaned widgets to full on segmentation faults. I'm handwaving quite a bit here but it's the best theory I have so far.

Requirements