Bank System - Vivaldi Bank (Deposit-Withdraw-Interest)

Version 1. 1

BUG FIXES

- Deposits disappearing / balance "resetting" after a while

Cause: opening "Withdraw" with an empty account on a later in-game day (for example, checking the account before the first deposit, or coming back  after withdrawing everything) caused a division by zero in the interest calculation. The balance was overwritten with -2147483648, and every deposit made after that was added on top of this negative number, so it could not be withdrawn. This was not related to saving or quitting the game: the balance was always saved correctly, the loss was just noticed after reloading.

Fix: interest calculation rewritten; an empty account no longer triggers it. Affected saves are repaired automatically: the next time you open the bank, all deposits made after the balance broke are restored.

- Balance cut down to 1,000,000

Cause: the 1,000,000 limit was applied to the whole balance, so an account above it was reduced to 1,000,000 on the next interest update.

Fix: the limit now only stops interest; your balance is never reduced.

- Interest lost when making a new deposit

Cause: a deposit reset the interest timer without paying out the interest earned since the last update.

Fix: earned interest is credited before every deposit and withdrawal.

- Withdraw slider possibly limited by the money in your pocket

The withdraw popup was passing your pocket money to the UI, which could cap the slider. It now shows your account balance instead. This may be the cause of the "only my last deposit can be withdrawn" reports.

- The dialogue could hang if the bank popup failed to open. It now times out safely.

- All mod logic moved into a single new file:

content/scripts/local/vivaldiBank.ws

The mod no longer overrides vanilla scripts (hudModuleDialog.ws and scene_functions.ws), so script conflicts with other mods are gone.

- Added console command "vbdinfo" (requires the debug console) that shows the raw account values, useful for bug reports.

HOW TO UPDATE (important)

1. Delete the old mod folder Mods/modVivaldiBankDeposit completely before installing the new version. If you only copy the new files over the old ones, the old content/scripts/game/ folder stays and the game will fail to compile scripts because BankDepositScene and BankWithdrawScene are defined twice.

2. If you used Script Merger with version 1. 0: open Script Merger, delete the merges involving hudModuleDialog.ws and scene_functions.ws (or delete Mods/mod0000_MergedFiles if you have no other merges), then run it again.

Otherwise the old bank code remains in the merged files and causes the same duplicate errors.

3. Your savegames are compatible; your balance is kept.

Added dialogues with the dwarf Vivaldi on the main square in Novigrad that let you place crowns on deposit. New dialogue lines have been added with lore explaining the cap, includes ai voice clone, lip-sync, and is localized into all available languages (ai). I also added muted version for people who hates ai slop.

Funds accrue to your bank account daily; the default interest rate is 1% per day, and the daily max interest payout is capped at 200 crowns. That means a 20,000-crown deposit reaches the daily interest cap of 200 crowns and will not earn more. You must have at least 1 crown for the dialogue to appear, and the withdrawal dialogue is also not displayed without any deposit.

The interest rate and daily cap are configurable in the mod settings (interest from 0. 01% to 10% per day, daily cap from 0 to 1000 per day):

Setting Cap to 0 will remove the daily interest limit. Setting the interest rate to 0% will remove interest and force the deposit to only accumulate money.

If you install mod manually please add VivaldiBankDeposit.xml to the dx12filelist.txt file (\The Witcher 3\bin\config\r4game\user_config_matrix\pc) to see mod settings. If you want bigger numbers you can change manually in VivaldiBankDeposit.xml at SLIDER;0;10;1001 (min;max;step; 1001 is 0. 01).

To ensure correct simulation the mod enforces limits: a maximum of 2000 simulated days (the maximum number of days that can pass without contacting the bank for which interest will be applied) and an account ceiling of 1,000,000 crowns. For performance reasons, interest calculations take place when the player withdraw bank account, rather than through continuous daily ticks.

Compound interest calculation is optimized by chec